Skip to content

chore(AspireDashboard): Cover connection string provider#1713

Merged
HofmeisterAn merged 1 commit into
developfrom
feature/cover-aspire-dashboard-connection-string-provider
Jun 24, 2026
Merged

chore(AspireDashboard): Cover connection string provider#1713
HofmeisterAn merged 1 commit into
developfrom
feature/cover-aspire-dashboard-connection-string-provider

Conversation

@HofmeisterAn

@HofmeisterAn HofmeisterAn commented Jun 24, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

What does this PR do?

This PR adds an assertion to test the Aspire dashboard connection string provider implementation and fixes an issue where the provider resolved the wrong method, causing it to enter an infinite loop.

Why is it important?

-

Related issues

-

Summary by CodeRabbit

  • Bug Fixes
    • Improved dashboard connection handling so the application now uses the correct dashboard address when building the host connection string.
    • Added verification that the dashboard endpoint remains reachable and returns a successful response.

@HofmeisterAn HofmeisterAn added bug Something isn't working chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups labels Jun 24, 2026
@netlify

netlify Bot commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 0fe69c8
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-dotnet/deploys/6a3c2a3ded6f3700086930b8
😎 Deploy Preview https://deploy-preview-1713--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 89b42730-3240-4cc3-8364-ae26d24cd9c0

📥 Commits

Reviewing files that changed from the base of the PR and between 9bbf81b and 0fe69c8.

📒 Files selected for processing (2)
  • src/Testcontainers.AspireDashboard/AspireDashboardConnectionStringProvider.cs
  • tests/Testcontainers.AspireDashboard.Tests/AspireDashboardContainerTest.cs

Walkthrough

The Aspire dashboard host connection string now comes from the dashboard address. The dashboard test still checks for HTTP 200 and now also verifies the dashboard address matches the container connection string.

Changes

Aspire dashboard host string

Layer / File(s) Summary
Provider update and test assertion
src/Testcontainers.AspireDashboard/AspireDashboardConnectionStringProvider.cs, tests/Testcontainers.AspireDashboard.Tests/AspireDashboardContainerTest.cs		 GetHostConnectionString() now returns Container.GetDashboardAddress(), and the dashboard test adds an assertion that GetDashboardAddress() equals GetConnectionString() while keeping the HTTP 200 check.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

module

Poem

A rabbit hopped by, soft and keen,
To see the dashboard run clean.
One string took a turn,
And tests gave a purr—
Hoppy paths, and all pixels serene.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description has the required sections, but 'Why is it important?' and 'How to test this PR' are effectively empty. Add a real rationale, link any related issues, and include test steps or commands so the template is complete.
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: fixing the AspireDashboard connection string provider and its test coverage.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/cover-aspire-dashboard-connection-string-provider

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@HofmeisterAn HofmeisterAn merged commit df03bbc into develop Jun 24, 2026
16 checks passed
@HofmeisterAn HofmeisterAn deleted the feature/cover-aspire-dashboard-connection-string-provider branch June 24, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@HofmeisterAn